search

taikoxyz / taiko-geth

An L2 execution engine implementation for the Taiko protocol. 🚚
https://geth.taiko.xyz
GNU Lesser General Public License v3.0
215 stars 149 forks source link

Add workflow and fix typos #182

Closed miles-six closed 7 months ago

miles-six commented 8 months ago

I fix some typos and want to add workflow for codespell check to eliminate typos in the future.

I have added a relatively simple filtering file to exclude certain words.

If you find it meaningful, you can modify the filtering conditions according to your needs.

The code quality is exceptionally high, so sincerely hope my PR can help make this repository more standardized.

davidtaikocha commented 7 months ago

Since this repo is a fork of go-ethereum, I think the better way to fix those typos is to open a PR in go-ethereum repo, and after its merged, we will merge the changes back.

miles-six commented 7 months ago

@davidtaikocha thank you sir, as you said,I fix these typos in go-ethereum repo , and be merged:https://github.com/ethereum/go-ethereum/pull/29288#event-12180785949

davidtaikocha commented 7 months ago

Great, we will include this when we merge back the upstream changes next time :)

miles-six commented 7 months ago

@davidtaikocha btw sir, the last question :Will Taiko's Poap of 2024 distribute in the future?

davidtaikocha commented 7 months ago

For your go-ethereum PR, I think no, it's basically a PR in another different project. Maybe u can try to make more contributions to this repo: https://github.com/taikoxyz/taiko-mono