search

taikoxyz / taiko-geth

An L2 execution engine implementation for the Taiko protocol. 🚚
https://geth.taiko.xyz
GNU Lesser General Public License v3.0
214 stars 147 forks source link

feat(all): preconfs #281

Closed cyberhorsey closed 6 days ago

mask-pp commented 4 months ago

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

cyberhorsey commented 4 months ago

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

mask-pp commented 4 months ago

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

YoGhurt111 commented 4 months ago

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

I agree to use a new API. This will avoid breaking the interface in some libs depending on eth's native SendTransaction.

cyberhorsey commented 4 months ago

Could you create a new API? But not break eth's origin eth_sendRawTransaction.

this doesn't break it, the two new arguments are optional. We can create a new API if we want, but perhaps this is easier for wallets to implement?

Maybe using a new API can be more clear, especially because this PR caused a large number of files to be changed.

I agree to use a new API. This will avoid breaking the interface in some libs depending on eth's native SendTransaction.

The team building the preconfs wants to use the same API for the testnet. ![Uploading Screenshot_20240627-084607.png…]()

davidtaikocha commented 4 months ago

Lets keep these changes in another branch instead of taiko branch.

mask-pp commented 2 months ago

Unless it is a version upgradation, please do not add extra logs or blank lines in unmodified areas.

mask-pp commented 2 months ago

Please use the unique CHANGE(taiko): tag when making any modifications.

cyberhorsey commented 2 months ago

Please use the unique CHANGE(taiko): tag when making any modifications.

yep, when this PR is ready for review I'll tag you, it's just constant crap rn because I push changes to log and test stuff.

davidtaikocha commented 6 days ago

Closed by https://github.com/taikoxyz/taiko-geth/pull/342/commits/266c8cabf4d9dae1c4c82db9cea04fb2a2f76a2e