taikoxyz / taiko-mono

A based rollup. 🥁
https://taiko.xyz
MIT License
4.16k stars 1.99k forks source link

chore(repo): add taiko-client to taiko-mono #16959

Closed d1onys1us closed 1 week ago

d1onys1us commented 2 weeks ago

summary of changes

This PR adds taiko-client into taiko-mono, so it can benefit from our CICD. There are two commits to review this PR:

next steps

  1. Let this merge into taiko-mono.
  2. Add the GAR_JSON_KEY to taiko-mono for the docker job. <- @davidtaikocha
  3. Rebase all PRs in taiko-client against this and open in taiko-mono, you'll just need to replace the workspace module path: github.com/taikoxyz/taiko-client -> github.com/taikoxyz/taiko-mono/packages/taiko-client.
  4. Move any github issues from taiko-client to taiko-mono. <- @d1onys1us
  5. Mark taiko-client as a public readonly archive, and remove it from the taikoxyz pinned repos. <- @dantaik
dantaik commented 1 week ago

According to @davidtaikocha there is one or two changes that needs to be merged into the codebase before merging this PR.

d1onys1us commented 1 week ago

@dantaik @davidtaikocha i fixed up this PR and got it ready for review. you can check my description, i split the PR into three logically separated commits for easier review of the changes.