taikoxyz / taiko-mono

A based rollup. 🥁
https://taiko.xyz
MIT License
4.16k stars 1.99k forks source link

chore(eventindexer): enhance indexer filter fetching latest block #16981

Closed fenghaojiang closed 1 week ago

fenghaojiang commented 2 weeks ago

chore(indexer): enhance indexer filter fetching latest block by replacing HeaderByNumber by BlockNumber

Previous: Using HeaderByNumber but other fields(except block number) not being used. Fetching latest block by BlockNumber should be better.

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 17.71%. Comparing base (f53766b) to head (8ff0755). Report is 430 commits behind head on main.

Files Patch % Lines
packages/eventindexer/indexer/filter.go 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #16981 +/- ## ========================================== - Coverage 26.82% 17.71% -9.12% ========================================== Files 105 45 -60 Lines 6188 1987 -4201 ========================================== - Hits 1660 352 -1308 + Misses 4348 1594 -2754 + Partials 180 41 -139 ``` | [Flag](https://app.codecov.io/gh/taikoxyz/taiko-mono/pull/16981/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=taikoxyz) | Coverage Δ | | |---|---|---| | [eventindexer](https://app.codecov.io/gh/taikoxyz/taiko-mono/pull/16981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=taikoxyz) | `17.71% <0.00%> (+0.49%)` | :arrow_up: | | [guardian-prover-health-check](https://app.codecov.io/gh/taikoxyz/taiko-mono/pull/16981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=taikoxyz) | `?` | | | [relayer](https://app.codecov.io/gh/taikoxyz/taiko-mono/pull/16981/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=taikoxyz) | `?` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xiaodino commented 1 week ago

@fenghaojiang I guess you need to rebase main branch in your PR.

fenghaojiang commented 1 week ago

@fenghaojiang I guess you need to rebase main branch in your PR.

Already rebased. Plz review it again.

cyberhorsey commented 1 week ago

Approved, LGTM.

gitpoap-bot[bot] commented 1 week ago

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Taiko Contributor:

GitPOAP: 2024 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.