tail-f-systems / JNC

JNC (Java NETCONF Client) is the name of a Java library for communicating with NETCONF agents, and a plugin for pyang (http://code.google.com/p/pyang/) to generate Java classes from YANG models, to be used by the JNC library.
Other
77 stars 87 forks source link

travis ci support #31

Closed alrighttheresham closed 10 years ago

alrighttheresham commented 10 years ago

Hi Klacke, some build updates to support autobuild using public travis ci. Look at the top of the readme.md file you'll see a link to the build status on travis. you'll need to goto travis-ci.org and link your github account so that you can auto build on commit, this is a trivial thing to do. then update the link in the readme.md to point to your travis account rather than mine.

summary of changes:

extend build system, to auto run the unit tests in the jnc directory.

add a travis yml file so that travis ci can auto build the project.

move readme to markdown so build status can be automatically reported on github page.

klacke commented 10 years ago

Hmm, you are adding 3 .jar files to git repo, I don't like that. Why do you feel that is necessary?

alrighttheresham commented 10 years ago

Hi Klacke for the CI system to work it needs to have access to all the dependencies to build and run the unit tests.

The three jars are; junit and its dependency and the ganymede ssh dependency used in the transport layer.

The license for all three jars support redistribution.

We are about to commit code to properly merge XML snippets with the NodeModel, the code includes a suite of tests that test the various merge combinations. In advance of the commit we’d like the build system to support automatically running the tests and the post commits to execute in a CI Server, hence the travis pull request.

Thanks, Damian.

On 17 Apr 2014, at 20:52, Claes Wikstrom notifications@github.com wrote:

Hmm, you are adding 3 .jar files to git repo, I don't like that. Why do you feel that is necessary?

— Reply to this email directly or view it on GitHub.

klacke commented 10 years ago

On 17/04/14 22:00, alrighttheresham wrote:

Hi Klacke for the CI system to work it needs to have access to all the dependencies to build and run the unit tests.

Ok,

The three jars are; junit and its dependency and the ganymede ssh dependency used in the transport layer.

Yes, I saw that

The license for all three jars support redistribution.

No problem,

But that still doesn't explain why we should check in .jar files in the git repo. You write

CI system to work it needs to have access

Fine, let the Travis CI system download or .. whatever those jar files ??? It's considered bad practice to check in .jar files is source repos

We are about to commit code to properly merge XML snippets with the NodeModel, the code includes a suite of tests that test the various merge combinations. In advance of the commit we’d like the build system to support automatically running the tests and the post commits to execute in a CI Server, hence the travis pull request.

Awesome !!

/klacke

alrighttheresham commented 10 years ago

deps now pulled from the internet, jars removed from github.

klacke commented 10 years ago

thx