tailcallhq / tailcall

High Performance GraphQL Runtime
https://tailcall.run
Apache License 2.0
1.28k stars 245 forks source link

fix: drop `unwrap` from `from_proto` #1739

Closed tusharmath closed 1 month ago

tusharmath commented 5 months ago

from_proto contains a few unwrap. Remove them and use Valid type here. Make sure to use Valid::from_iter for when one needs to check iterables.

tusharmath commented 5 months ago

/bounty 25

algora-pbc[bot] commented 5 months ago

## 💎 $25 bounty • Tailcall Inc.

### Steps to solve: 1. Start working: Comment /attempt #1739 with your implementation plan 2. Submit work: Create a pull request including /claim #1739 in the PR body to claim the bounty 3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

🙏 Thank you for contributing to tailcallhq/tailcall! 🧐 Checkout our guidelines before you get started. 💵 More about our bounty program.

Attempt Started (GMT+0) Solution
🔴 @ssddOnTop Apr 16, 2024, 6:53:23 AM WIP
🟡 @emekaokoli19 Apr 18, 2024, 12:44:46 AM WIP
🔴 @Rutik7066 Jun 11, 2024, 8:58:07 PM WIP
🔴 @Shylock-Hg Jul 24, 2024, 11:27:24 AM WIP
ssddOnTop commented 5 months ago

/attempt

Algora profile Completed bounties Tech Active attempts Options
@ssddOnTop 38 tailcallhq bounties
Rust, Java,
C & more
Cancel attempt
algora-pbc[bot] commented 5 months ago

@ssddOnTop: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

algora-pbc[bot] commented 5 months ago

[!NOTE] The user @ssddOnTop is already attempting to complete issue #1739 and claim the bounty. We recommend checking in on @ssddOnTop's progress, and potentially collaborating, before starting a new solution.

algora-pbc[bot] commented 5 months ago

@emekaokoli19: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

timburrows commented 5 months ago

In the queue

VasuDevrani commented 4 months ago

is it still valid or fixed?

Rutik7066 commented 3 months ago

/attempt #1739

Algora profile Completed bounties Tech Active attempts Options
@Rutik7066    1 tailcallhq bounty
+ 8 bounties from 5 projects
Go, Rust,
Python & more
Cancel attempt
algora-pbc[bot] commented 3 months ago

[!NOTE] The user @emekaokoli19 is already attempting to complete issue #1739 and claim the bounty. We recommend checking in on @emekaokoli19's progress, and potentially collaborating, before starting a new solution.

algora-pbc[bot] commented 3 months ago

@Rutik7066: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

Shylock-Hg commented 2 months ago

/attempt #1739

Algora profile Completed bounties Tech Active attempts Options
@Shylock-Hg    8 tailcallhq bounties
+ 3 bounties from 3 projects
C++, C,
Shell & more
Cancel attempt
algora-pbc[bot] commented 2 months ago

[!NOTE] The user @emekaokoli19 is already attempting to complete issue #1739 and claim the bounty. We recommend checking in on @emekaokoli19's progress, and potentially collaborating, before starting a new solution.

Shylock-Hg commented 2 months ago

@tusharmath Currently, there is only one unwrap called in from_proto.rs:138, and I think it will never panic because the container is not empty. Should we still remove it?

algora-pbc[bot] commented 2 months ago

@Shylock-Hg: Reminder that in 1 days the bounty will become up for grabs, so please submit a pull request before then 🙏

github-actions[bot] commented 1 month ago

Action required: Issue inactive for 30 days. Status update or closure in 7 days.

github-actions[bot] commented 1 month ago

Issue closed after 7 days of inactivity.