sirish123
commented
4 months ago Hey! @ranjitmahadik new to rust but will give this a shot, Here is what I think will work, this is the code snippet as given in the mocha documentation and by the look of it we have to add a weigher function to assess the true size or byte length.
// Evict based on the byte length of strings in the cache.
let cache = Cache::builder()
// A weigher closure takes &K and &V and returns a u32
// representing the relative size of the entry.
.weigher(|_key, value: &String| -> u32 {
value.len().try_into().unwrap_or(u32::MAX)
})
// This cache will hold up to 32MiB of values.
.max_capacity(32 * 1024 * 1024)
.build();As you can see below the original code in tailcal, the modification in tailcall is essentially we just have to add the weigher function. After i create HttpCacheManagerByteSize with the weigher function, from there on I dont know what is the best way to invoke it i.e. how does one specifiy that he needs Byte level control in order to invoke HttpCacheManagerByteSize rather than the default HttpCacheManager
impl HttpCacheManager {
pub fn new(cache_size: u64) -> Self {
let cache = Cache::builder()
.eviction_policy(EvictionPolicy::lru())
.max_capacity(cache_size)
.build();
Self { cache: Arc::new(cache) }
}
pub async fn clear(&self) -> Result<()> {
self.cache.invalidate_all();
self.cache.run_pending_tasks().await;
Ok(())
}
}impl HttpCacheManagerByteSize {
pub fn new(cache_size: u64) -> Self {
let cache = Cache::builder()
.eviction_policy(EvictionPolicy::lru())
.weigher(|_key, value: &String| -> u32 {
value.len().try_into().unwrap_or(u32::MAX)
})
.max_capacity(cache_size)
.build();
Self { cache: Arc::new(cache) }
}
pub async fn clear(&self) -> Result<()> {
self.cache.invalidate_all();
self.cache.run_pending_tasks().await;
Ok(())
}
}
laststylebender14
tusharmath
github-actions[bot]
Description:
Currently, in our system, there is provision to set the HTTP cache size in terms of the number of entries a cache can hold, which may not be the most efficient approach. I propose allowing users to specify the cache size in terms of total bytes rather than the number of entries.
Presently, users define the cache size as the maximum number of entries it can hold using the
@upstream(httpCache: X)directive.Following example limits the cache to 42 entries.
Following example specifies a cache of 2 MB.
This feature request suggests transitioning to a byte-based specification to provide more granular control over cache size allocation and better accommodate diverse data sizes and resource requirements.
Technical requirements