Closed Rutik7066 closed 1 week ago
Attention: Patch coverage is 87.09677%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 85.70%. Comparing base (
f1d8feb
) to head (05cf779
).
Files | Patch % | Lines |
---|---|---|
src/cli/tc.rs | 0.00% | 6 Missing :warning: |
tailcall-aws-lambda/src/main.rs | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Report | Sun, June 23, 2024 at 12:23:07 UTC |
Project | tailcall |
Branch | 2261/merge |
Testbed | benchmarking-runner |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
from_json_bench | ✅ (view plot) | 7,214,400.00 (+1.25%) | 7,258,797.36 (99.39%) |
group_by | ✅ (view plot) | 545.22 (-4.26%) | 637.24 (85.56%) |
input/args.missing | ✅ (view plot) | 24.97 (+3.55%) | 27.39 (91.16%) |
input/args.nested.existing | ✅ (view plot) | 52.88 (+10.72%) | 62.14 (85.09%) |
input/args.nested.missing | ✅ (view plot) | 36.68 (-3.69%) | 40.92 (89.63%) |
input/args.root | ✅ (view plot) | 50.93 (+15.23%) | 59.36 (85.80%) |
input/headers.existing | ✅ (view plot) | 32.24 (+1.93%) | 33.79 (95.42%) |
input/headers.missing | ✅ (view plot) | 31.60 (+2.87%) | 33.62 (94.00%) |
input/value.missing | ✅ (view plot) | 23.17 (-1.17%) | 25.00 (92.69%) |
input/value.nested.existing | ✅ (view plot) | 41.06 (-1.16%) | 45.07 (91.10%) |
input/value.nested.missing | ✅ (view plot) | 34.65 (-5.27%) | 38.69 (89.56%) |
input/value.root | ✅ (view plot) | 37.35 (-1.96%) | 41.59 (89.80%) |
input/vars.existing | ✅ (view plot) | 8.17 (+4.66%) | 8.94 (91.43%) |
input/vars.missing | ✅ (view plot) | 11.35 (+15.62%) | 13.29 (85.37%) |
synth_nested | ✅ (view plot) | 21,156.00 (+0.35%) | 21,857.10 (96.79%) |
test_batched_body | ✅ (view plot) | 2,550.30 (-99.28%) | 1,791,281.98 (0.14%) |
test_batched_body #2 | ✅ (view plot) | 1,703,100.00 (+0.07%) | 1,825,646.11 (93.29%) |
test_data_loader | ✅ (view plot) | 470,730.00 (+0.33%) | 486,068.19 (96.84%) |
test_handle_request | ✅ (view plot) | 154,420.00 (-1.23%) | 172,331.71 (89.61%) |
test_http_execute_method | ✅ (view plot) | 17,692.00 (-2.77%) | 19,290.69 (91.71%) |
with_mustache_expressions | ✅ (view plot) | 1,149.50 (-1.45%) | 1,230.92 (93.39%) |
with_mustache_literal | ✅ (view plot) | 743.56 (+3.05%) | 775.74 (95.85%) |
Copy of the PR here — https://github.com/tailcallhq/tailcall/pull/2260/commits
Summary:
chore: dropped pub fields from config module
Issue Reference(s):
Fixes #2256 /claim #2256 Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>