tailcallhq / tailcall

High Performance GraphQL Runtime
https://tailcall.run
Apache License 2.0
1.18k stars 209 forks source link

chore: dropped pub fields from config module #2263

Closed bnchi closed 1 week ago

bnchi commented 1 week ago

Summary:

Issue Reference(s):
Fixes #2256

Build & Testing:

Checklist:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 92.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.72%. Comparing base (ff14331) to head (67bea91). Report is 3 commits behind head on main.

Files Patch % Lines
src/cli/tc.rs 0.00% 5 Missing :warning:
tailcall-aws-lambda/src/main.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2263 +/- ## ========================================== + Coverage 85.69% 85.72% +0.03% ========================================== Files 219 219 Lines 21043 21061 +18 ========================================== + Hits 18033 18055 +22 + Misses 3010 3006 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

🐰Bencher

ReportSun, June 23, 2024 at 12:10:21 UTC
Projecttailcall
Branch2263/merge
Testbedbenchmarking-runner
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
from_json_bench✅ (view plot)7,103,700.00 (-0.27%)7,255,910.93 (97.90%)
group_by✅ (view plot)569.64 (-0.03%)637.68 (89.33%)
input/args.missing✅ (view plot)25.52 (+5.84%)27.40 (93.17%)
input/args.nested.existing✅ (view plot)54.91 (+14.93%)62.20 (88.28%)
input/args.nested.missing✅ (view plot)39.72 (+4.24%)40.94 (97.02%)
input/args.root✅ (view plot)51.54 (+16.56%)59.44 (86.71%)
input/headers.existing✅ (view plot)32.70 (+3.39%)33.79 (96.78%)
input/headers.missing✅ (view plot)31.73 (+3.32%)33.62 (94.40%)
input/value.missing✅ (view plot)23.23 (-0.96%)25.00 (92.90%)
input/value.nested.existing✅ (view plot)40.56 (-2.36%)45.07 (90.00%)
input/value.nested.missing✅ (view plot)37.03 (+1.20%)38.68 (95.72%)
input/value.root✅ (view plot)35.32 (-7.28%)41.62 (84.86%)
input/vars.existing✅ (view plot)7.47 (-4.03%)8.70 (85.85%)
input/vars.missing✅ (view plot)11.37 (+16.28%)13.16 (86.42%)
synth_nested✅ (view plot)22,453.00 (+5.43%)23,225.29 (96.67%)
test_batched_body✅ (view plot)2,876.30 (-99.20%)1,807,848.75 (0.16%)
test_batched_body #2✅ (view plot)1,631,400.00 (-4.13%)1,826,043.26 (89.34%)
test_data_loader✅ (view plot)464,370.00 (-1.03%)486,098.88 (95.53%)
test_handle_request✅ (view plot)152,750.00 (-2.33%)172,376.72 (88.61%)
test_http_execute_method✅ (view plot)18,222.00 (+0.10%)19,294.52 (94.44%)
with_mustache_expressions✅ (view plot)1,183.20 (+1.44%)1,230.77 (96.13%)
with_mustache_literal✅ (view plot)697.71 (-3.25%)775.13 (90.01%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
tusharmath commented 1 week ago

Merged it by mistake

bnchi commented 1 week ago

Merged it by mistake

re-opened here #2274

@tusharmath