Closed meskill closed 2 days ago
Attention: Patch coverage is 71.05263%
with 55 lines
in your changes missing coverage. Please review.
Project coverage is 85.79%. Comparing base (
f464794
) to head (baf8ba3
). Report is 1 commits behind head on main.:exclamation: Current head baf8ba3 differs from pull request most recent head f90b0f0
Please upload reports for the commit f90b0f0 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/core/data_loader/dedupe.rs | 71.05% | 55 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Report | Thu, June 27, 2024 at 15:49:02 UTC |
Project | tailcall |
Branch | 2291/merge |
Testbed | benchmarking-runner |
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
---|---|---|---|---|---|
test_handle_request | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 189,790.00 (+21.11%) | 174,380.70 (108.84%) |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
from_json_bench | ✅ (view plot) | 7,154,700.00 (+0.31%) | 7,260,454.91 (98.54%) |
group_by | ✅ (view plot) | 548.20 (-2.99%) | 629.35 (87.11%) |
input/args.missing | ✅ (view plot) | 25.03 (+3.82%) | 27.37 (91.46%) |
input/args.nested.existing | ✅ (view plot) | 54.88 (+15.14%) | 61.80 (88.80%) |
input/args.nested.missing | ✅ (view plot) | 38.16 (+0.27%) | 40.86 (93.37%) |
input/args.root | ✅ (view plot) | 50.90 (+15.50%) | 58.94 (86.36%) |
input/headers.existing | ✅ (view plot) | 30.53 (-3.51%) | 33.88 (90.10%) |
input/headers.missing | ✅ (view plot) | 29.34 (-4.48%) | 33.74 (86.97%) |
input/value.missing | ✅ (view plot) | 23.12 (-1.32%) | 24.98 (92.54%) |
input/value.nested.existing | ✅ (view plot) | 41.21 (-0.90%) | 45.09 (91.40%) |
input/value.nested.missing | ✅ (view plot) | 37.03 (+0.87%) | 38.69 (95.70%) |
input/value.root | ✅ (view plot) | 37.41 (-1.62%) | 41.54 (90.06%) |
input/vars.existing | ✅ (view plot) | 8.18 (+5.26%) | 9.07 (90.21%) |
input/vars.missing | ✅ (view plot) | 11.41 (+13.36%) | 13.46 (84.77%) |
synth_nested | ✅ (view plot) | 20,959.00 (+0.11%) | 21,452.24 (97.70%) |
test_batched_body | ✅ (view plot) | 2,907.70 (-98.76%) | 1,451,893.29 (0.20%) |
test_batched_body #2 | ✅ (view plot) | 1,710,300.00 (+0.53%) | 1,822,538.65 (93.84%) |
test_data_loader | ✅ (view plot) | 465,570.00 (-0.72%) | 485,188.73 (95.96%) |
test_handle_request | 🚨 (view plot | view alert) | 189,790.00 (+21.11%) | 174,380.70 (108.84%) |
test_http_execute_method | ✅ (view plot) | 18,582.00 (+2.34%) | 19,245.94 (96.55%) |
with_mustache_expressions | ✅ (view plot) | 1,176.80 (+0.96%) | 1,229.69 (95.70%) |
with_mustache_literal | ✅ (view plot) | 696.69 (-3.41%) | 777.67 (89.59%) |
Summary:
Briefly describe the changes made in this PR.
Issue Reference(s):
Fixes #2276
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>