fix: null enum - Githubissues

tailcallhq / tailcall

High Performance GraphQL Runtime

https://tailcall.run

Apache License 2.0

1.19k stars 213 forks source link

fix: null enum #2314

Closed ouertani closed 4 days ago

ouertani commented 4 days ago

Summary:
Briefly describe the changes made in this PR.

inner null enum failed to resolved.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

[ X] I ran cargo test successfully.
[ X] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[ X] I have added relevant unit & integration tests.
[ ] I have updated the documentation accordingly.
[X ] I have performed a self-review of my code.
[ ] PR follows the naming convention of <type>(<optional scope>): <title>

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.44%. Comparing base (2fe46d4) to head (c3f1cd9).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2314 +/- ## ======================================= Coverage 85.44% 85.44% ======================================= Files 236 236 Lines 22336 22336 ======================================= Hits 19086 19086 Misses 3250 3250 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ouertani commented 4 days ago

tried to fix with https://github.com/async-graphql/async-graphql/pull/1551 but actually this PR should resolve the issue.

tusharmath commented 4 days ago

Thanks @ouertani! Overall PR looks great, just a tiny little feedback about the test.