fix: recursive filter - Githubissues

tailcallhq / tailcall

High Performance GraphQL Runtime

https://tailcall.run

Apache License 2.0

1.19k stars 213 forks source link

fix: recursive filter #2321

Closed ouertani closed 3 days ago

ouertani commented 3 days ago

Summary:
Briefly describe the changes made in this PR.

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

[ X] I ran cargo test successfully.
[X ] I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

[X ] I have added relevant unit & integration tests.
[ ] I have updated the documentation accordingly.
[ ] I have performed a self-review of my code.
[ ] PR follows the naming convention of <type>(<optional scope>): <title>

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.50%. Comparing base (73c7fc1) to head (de5f3ed). Report is 3 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #2321 +/- ## ========================================== + Coverage 85.43% 85.50% +0.06% ========================================== Files 234 234 Lines 22232 22419 +187 ========================================== + Hits 18995 19170 +175 - Misses 3237 3249 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tusharmath commented 3 days ago

The gif file is also changed. Is that intentional?

ouertani commented 3 days ago

The gif file is also changed. Is that intentional?

Ah! not intentional, an internal program checking all gif files :(