Open varshith257 opened 3 days ago
Attention: Patch coverage is 15.06849%
with 62 lines
in your changes missing coverage. Please review.
Project coverage is 85.79%. Comparing base (
b55acbf
) to head (d660eb6
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tusharmath ready for review!
Report | Fri, July 5, 2024 at 12:23:12 UTC |
Project | tailcall |
Branch | 2328/merge |
Testbed | benchmarking-runner |
🚨 2 ALERTS: Threshold Boundary Limits exceeded!
Benchmark | Measure (units) | View | Value | Lower Boundary | Upper Boundary |
---|---|---|---|---|---|
test_handle_request | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 345,220.00 (+120.68%) | 189,495.62 (182.18%) | |
with_mustache_literal | Latency (nanoseconds (ns)) | 🚨 (view plot | view alert) | 797.45 (+10.39%) | 779.59 (102.29%) |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|
from_json_bench | ✅ (view plot) | 6,125,000.00 (-12.50%) | 7,715,431.49 (79.39%) |
group_by | ✅ (view plot) | 495.74 (-11.28%) | 628.93 (78.82%) |
input/args.missing | ✅ (view plot) | 25.52 (+5.68%) | 27.58 (92.56%) |
input/args.nested.existing | ✅ (view plot) | 54.72 (+15.02%) | 61.51 (88.95%) |
input/args.nested.missing | ✅ (view plot) | 38.34 (+0.74%) | 40.86 (93.84%) |
input/args.root | ✅ (view plot) | 51.28 (+16.68%) | 58.54 (87.59%) |
input/headers.existing | ✅ (view plot) | 30.53 (-3.45%) | 33.94 (89.97%) |
input/headers.missing | ✅ (view plot) | 29.14 (-5.08%) | 33.74 (86.37%) |
input/value.missing | ✅ (view plot) | 23.39 (-0.15%) | 24.97 (93.65%) |
input/value.nested.existing | ✅ (view plot) | 41.85 (+0.58%) | 45.11 (92.77%) |
input/value.nested.missing | ✅ (view plot) | 37.38 (+1.64%) | 38.65 (96.71%) |
input/value.root | ✅ (view plot) | 37.22 (-1.96%) | 41.47 (89.76%) |
input/vars.existing | ✅ (view plot) | 7.47 (-3.37%) | 9.00 (82.95%) |
input/vars.missing | ✅ (view plot) | 7.84 (-21.93%) | 13.41 (58.44%) |
synth_nested | ✅ (view plot) | 14,479.00 (-21.17%) | 25,229.54 (57.39%) |
test_batched_body | ✅ (view plot) | 2,078.80 (-98.64%) | 1,165,326.85 (0.18%) |
test_batched_body #2 | ✅ (view plot) | 1,609,300.00 (-5.17%) | 1,821,037.63 (88.37%) |
test_data_loader | ✅ (view plot) | 385,430.00 (-16.76%) | 512,706.72 (75.18%) |
test_handle_request | 🚨 (view plot | view alert) | 345,220.00 (+120.68%) | 189,495.62 (182.18%) |
test_handle_request_jit | ✅ (view plot) | 231,900.00 | |
test_http_execute_method | ✅ (view plot) | 14,582.00 (-18.16%) | 20,328.43 (71.73%) |
with_mustache_expressions | ✅ (view plot) | 1,153.70 (-0.85%) | 1,233.17 (93.56%) |
with_mustache_literal | 🚨 (view plot | view alert) | 797.45 (+10.39%) | 779.59 (102.29%) |
Moving to draft to reduce noise and improve CI efficiency. Once you are ready just mark it as "ready to review". Feel free to give a shoutout on the #contributors channel on Discord if you want immediate attention.
Issue Reference(s):
Fixes #2325 /claim #2325 /split @ssddOnTop 60%
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>