tailcallhq / tailcall

High Performance GraphQL Runtime
https://tailcall.run
Apache License 2.0
1.29k stars 254 forks source link

refactor: use from_iter for initializing JsonLikeObject #3091

Open meskill opened 3 weeks ago

meskill commented 3 weeks ago

Summary:

Attempt to use from_iter initialization to create serde_json_borrow::Value. While it seems more flexible interface to do the performance is very similar to the base branch or slightly worse. So I'll leave this pr just for reference that I've tried use only iterator

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

Checklist:

github-actions[bot] commented 3 weeks ago

🐰 Bencher Report

Branch3091/merge
Testbedbenchmarking-runner

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,168,500.00
group_by📈 view plot
⚠️ NO THRESHOLD
481.93
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.61
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.92
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
37.57
input/args.root📈 view plot
⚠️ NO THRESHOLD
38.50
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
30.43
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
29.46
input/value.missing📈 view plot
⚠️ NO THRESHOLD
23.18
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
42.34
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
37.46
input/value.root📈 view plot
⚠️ NO THRESHOLD
40.67
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
7.79
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
8.11
synth_nested📈 view plot
⚠️ NO THRESHOLD
109,690.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
46,726.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,917.30
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,518,300.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
391,050.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
127,890.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
55,108.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
15,289.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,111.20
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
741.32
🐰 View full continuous benchmarking report in Bencher
github-actions[bot] commented 6 days ago

Action required: PR inactive for 5 days. Status update or closure in 10 days.