tailcallhq / tailcall

High Performance GraphQL Runtime
https://tailcall.run
Apache License 2.0
1.3k stars 254 forks source link

refactor(blueprint): remove configuration related items from blueprint #3123

Closed karatakis closed 5 days ago

karatakis commented 1 week ago

Summary:
To give the option to read configuration options from a separate file, we need to separate the configuration options from the schema options. This PR removes all configuration-related options from the blueprint and puts them into RuntimeConfiguration

Build & Testing:

Checklist:

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 84.82759% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.89%. Comparing base (46d7756) to head (9f4a9c5). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
tailcall-aws-lambda/src/main.rs 0.00% 8 Missing :warning:
tailcall-wasm/src/builder.rs 0.00% 7 Missing :warning:
src/cli/tc/check.rs 0.00% 2 Missing :warning:
src/core/http/request_handler.rs 92.00% 2 Missing :warning:
src/cli/server/server_config.rs 94.44% 1 Missing :warning:
src/cli/tc/run.rs 0.00% 1 Missing :warning:
...rc/core/blueprint/runtime_config/runtime_config.rs 96.42% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3123 +/- ## ========================================== - Coverage 86.93% 86.89% -0.04% ========================================== Files 275 276 +1 Lines 26889 26945 +56 ========================================== + Hits 23375 23413 +38 - Misses 3514 3532 +18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

github-actions[bot] commented 6 days ago

🐰 Bencher Report

Branch3123/merge
Testbedbenchmarking-runner

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
from_json_bench📈 view plot
⚠️ NO THRESHOLD
6,175,400.00
group_by📈 view plot
⚠️ NO THRESHOLD
498.26
input/args.missing📈 view plot
⚠️ NO THRESHOLD
22.04
input/args.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.26
input/args.nested.missing📈 view plot
⚠️ NO THRESHOLD
36.38
input/args.root📈 view plot
⚠️ NO THRESHOLD
37.55
input/headers.existing📈 view plot
⚠️ NO THRESHOLD
32.99
input/headers.missing📈 view plot
⚠️ NO THRESHOLD
31.89
input/value.missing📈 view plot
⚠️ NO THRESHOLD
22.29
input/value.nested.existing📈 view plot
⚠️ NO THRESHOLD
41.31
input/value.nested.missing📈 view plot
⚠️ NO THRESHOLD
33.14
input/value.root📈 view plot
⚠️ NO THRESHOLD
38.87
input/vars.existing📈 view plot
⚠️ NO THRESHOLD
8.51
input/vars.missing📈 view plot
⚠️ NO THRESHOLD
8.42
synth_nested📈 view plot
⚠️ NO THRESHOLD
92,772.00
synth_nested_borrow📈 view plot
⚠️ NO THRESHOLD
41,904.00
test_batched_body📈 view plot
⚠️ NO THRESHOLD
1,854.70
test_batched_body #2📈 view plot
⚠️ NO THRESHOLD
1,505,100.00
test_data_loader📈 view plot
⚠️ NO THRESHOLD
386,330.00
test_handle_request📈 view plot
⚠️ NO THRESHOLD
127,880.00
test_handle_request_jit📈 view plot
⚠️ NO THRESHOLD
62,813.00
test_http_execute_method📈 view plot
⚠️ NO THRESHOLD
14,858.00
with_mustache_expressions📈 view plot
⚠️ NO THRESHOLD
1,127.70
with_mustache_literal📈 view plot
⚠️ NO THRESHOLD
702.87
🐰 View full continuous benchmarking report in Bencher
tusharmath commented 5 days ago

Closing this PR because splitting blueprint wasn't the primary objective nor does it make our actual objective of splitting config easier.