search

tailhook / humantime

A parser and formatter for std::time::{SystemTime, Duration}
Apache License 2.0
283 stars 34 forks source link

Migrate to 2018 edition #11

Closed koushiro closed 4 years ago

koushiro commented 4 years ago
koushiro commented 4 years ago

BTW, how about migrating to 2018 edition?

tailhook commented 4 years ago

I'm okay with migrating to edition 2018. But rustfmt.... Here is my comment on previous PR doing this: https://github.com/tailhook/humantime/pull/9#issuecomment-547374575. I also prefer max_width=80 it's more comfortable side-by-side editing and also for reviewing diffs on github.

koushiro commented 4 years ago

@tailhook PTAL again :)

tailhook commented 4 years ago

Looks nice. Thank you!

tailhook commented 4 years ago

By the way, env_logger which depends on this, has MSRV 1.31. Is there anything that requires 1.32?

tailhook commented 4 years ago

Hm, it seems self:: is required on 1.31, and also tests don't work.

koushiro commented 4 years ago

At first, I just raised MSRV to 1.32 in order to use rand 0.7 in the test. Now it seems that we must add self:: :laughing: