search

tailhook / humantime

A parser and formatter for std::time::{SystemTime, Duration}
Apache License 2.0
285 stars 36 forks source link

Update doc #9

Closed xoac closed 4 years ago

xoac commented 4 years ago

apply rustfmt on this lib sync doc in src/lib.rs with information in README.md

tailhook commented 4 years ago

I'm okay with doc update. But any specific reason why you have applied rustfmt? Most (if not all) things aren't improvements here, some are harmful. To name a few:

  1. Bytes in declaration of buf (date.rs:32) are aligned to have newlines at separators T and .
  2. Loop comment in date.rs:278 became in the wrong place
  3. I like the contrast between an = assignment and configuration="parameters" (spaces around equals sign).

I understand rustfmt is a useful tradeoff for projects with high contribution traffic where it's easier to settle on rustfmt than to teach everyone good style. But this crate is prettly low-maintenance. And there is no need for such extra changes.

xoac commented 4 years ago

I used rustfmt because it's done im my IDE on save. So no general purpose.

I think I can come back to master, Add skip attributes and then do rustfmt and update doc.

or just update doc. whatever you prefer

tailhook commented 4 years ago

Thanks, I prefer just updating docs.

xoac commented 4 years ago

Done

tailhook commented 4 years ago

Merged. Thanks!