search

tailhook / unshare

The low-level linux containers creation library for rust
Apache License 2.0
124 stars 27 forks source link

Support changing the Command program #13

Open Popog opened 5 years ago

Popog commented 5 years ago

Since Command mostly adheres to a builder pattern, and spawn can be called multiple times, it would be useful to change the program.

Motivating example: a user wants to fall back to an less common filename or path in the case of a failure to spawn.

Proposed signature would look: pub fn program<S: AsRef<OsStr>>(&mut self, program: S) -> &mut Command

Calling program would imply calling arg0.

It doesn't look like the effected filename has a whole lot of other implications to worry about.

I could put together a PR for this if you're interested.

tailhook commented 4 years ago

Sorry for late reply. I somehow missed the notification. Looks good! Feel free to make PR.