search

tailhook / unshare

The low-level linux containers creation library for rust
Apache License 2.0
124 stars 27 forks source link

Command::before_unfreeze should return &mut self to allow chaining in builder pattern #15

Closed joshtriplett closed 4 years ago

joshtriplett commented 4 years ago

Most methods of Command return self, to allow chaining them together in the builder pattern. However, Command::before_unfreeze doesn't return anything. Please consider having it (and before_exec) return self as well.

tailhook commented 4 years ago

Nice catch. Also, since this is technically a breaking change, we should also make before_exec unsafe like stdlib did. Do you want to make a PR?

joshtriplett commented 4 years ago

https://github.com/tailhook/unshare/pull/16

tailhook commented 4 years ago

Done!