port to aarch64 - Githubissues

tailhook / unshare

The low-level linux containers creation library for rust

Apache License 2.0

124 stars 27 forks source link

Closed nivkner closed 7 years ago

nivkner commented 7 years ago

Hello @tailhook. This crate fails to compile on aarch64 for two reasons:

nix 0.4.2
using the integer type specific to x86_64 instead of the type provided by libc which is meant to abstract over platform differences.

I changed nix's version to 0.5.1; I could have gone further but this is the minimal change necessary for the port.

The unwrap should be as safe as the original function that took a number. If there is no corresponding flag, it fails.

tailhook commented 7 years ago

Looks good. Thanks!

This doesn't change the public API right?

tailhook commented 7 years ago

Notes to my self:

to_clone_flags implementation is leaked. So it's a breaking change. We need to find out whether CloneFlags should be exported or the method made non-public.
We re-export SigNum which may also introduce incompatibilities with nix crate upgrades.

That's it for breaking changes. Not sure about 2nd, but first is definitely triggers v0.2