search

tailhook / vagga-box

A virtualbox wrapper around vagga
9 stars 4 forks source link

Improve UX in upgrade_vagga command. Resolves #7 #8

Closed seedofjoy closed 6 years ago

seedofjoy commented 6 years ago

Improve UX in upgrade_vagga command: print old vagga version and successful message with new version.

Before:

~ > vagga _box upgrade_vagga
Connection to 127.0.0.1 closed.

After:

~ > vagga _box upgrade_vagga
Starting upgrade vagga. Current version: v0.8.0-4-somevar
Connection to 127.0.0.1 closed.
Vagga successfully upgraded to v0.8.0-5-ge88d28b
All OK!

I'm not sure about Connection to 127.0.0.1 closed. phrase. It's prints to stderr, so if we want to remove it, I think, we should parse for specified phrase...

tailhook commented 6 years ago

Oh, sorry forgot about this PR. Now, I'm not sure why I haven't applied it right away. Is there anything about this PR that we discussed offline?

seedofjoy commented 6 years ago

Is there anything about this PR that we discussed offline?

I don't think so.

Actually, I'm using vaggabox with this PR with no issues.

tailhook commented 6 years ago

Okay. Merged. Thanks!