tailhook / vagga

Vagga is a containerization tool without daemons
http://vagga.readthedocs.org
MIT License
1.86k stars 96 forks source link

Allow to pass pip dependencies to get-pip script #554

Closed anti-social closed 2 years ago

anti-social commented 2 years ago

Some other variants to name it:

tailhook commented 2 years ago

This is interesting: wasn't that /non-existent from #553, because this allowed pip not install setuptools (and you could set your own version in requirements.txt)? Is there something simple that requires old setuptools that I can test with?

Although, I'm not against this solution even if the above is true. It maybe somewhat more straightforward approach.

Let's name it get-pip-args. But keep the example with setuptools in docs, so it's more or less clean what it is for.

anti-social commented 2 years ago

There are a lot of issues: https://github.com/pypa/setuptools/issues?q=is%3Aissue+use_2to3

anti-social commented 2 years ago

because this allowed pip not install setuptools (and you could set your own version in requirements.txt)

At the moment pip always installs its own setuptools into target path.

tailhook commented 2 years ago

Okay. Let's just rename it to get-pip-args as we don't validate them anyway.