search

tailhook / vagga

Vagga is a containerization tool without daemons
http://vagga.readthedocs.org
MIT License
1.86k stars 96 forks source link

Apt cache overlay #568

Closed anti-social closed 2 years ago

tailhook commented 2 years ago

Okay. So all looks good so far.

I think we should proceed with copying files for now and maybe try to optimize (i.e. have a mountpoint that crosses both cache-dir and storage-dir) later. With the amount of file operations we have to make a container it should not make much difference.

tailhook commented 2 years ago

I've also merged github-actions support, so please rebase on top of that, so we see tests here.

anti-social commented 2 years ago

@tailhook Could you review it

tailhook commented 2 years ago

.owner(CopyOwnerPolicy::Set(.. is a bit verbose, but since used only single time looks fine.

Also Preserve should be removed instead of commented out.

The failing test is the flaky one, right?

Other than that it looks good to me.

anti-social commented 2 years ago

Also updated Lock. It is now possible to clean up lock file.

tailhook commented 2 years ago

Merged. Thanks!