tailosoft / jhipster-primeng-blueprint

This blueprint can be used to generate jhipster project with primeng frontend instead of bootstrap (work in progress)
Apache License 2.0
26 stars 20 forks source link

Fix of #16 Prettier error when [re]generating entity #18

Open smunir opened 4 years ago

smunir commented 4 years ago

template updated for fix of #16. currentSearch property declaration added.

yelhouti commented 4 years ago

@smunir it seems liks tests are not passing, if elastic search is not used the field should not be added, please add tests and try again. Thank you

smunir commented 4 years ago

I just fixed compilation errors, couldn't manage to study your blueprint fully yet, I am afraid you would have to fix

yelhouti commented 4 years ago

@smunir could you rebase your PR please, we improved the design, I can't understand what your are trying to do

yelhouti commented 4 years ago

@smunir please add some tests, you will see the problem with your code and will be able to fix it.

smunir commented 4 years ago

@smunir could you rebase your PR please, we improved the design, I can't understand what your are trying to do

Yup I checked out the improvements. In fact I just fixed 2 compile errors in entity-management.component.ts.ejs

if (this.currentSearch) {
    return this.<%= entityInstance %>Service.search(this.<%= entityInstance %>Table.filters.global.value)
} else {
    return this.<%= entityInstance %>Service.query(lazyLoadEventToServerQueryParams(this.<%= entityInstance %>Table.createLazyLoadMetadata()));
}

You can fix them and discard my PR