search

tailosoft / jhipster-primeng-blueprint

This blueprint can be used to generate jhipster project with primeng frontend instead of bootstrap (work in progress)
Apache License 2.0
26 stars 20 forks source link

feat: build and run from Docker Support #36

Open Rajpratik71 opened 3 years ago

Rajpratik71 commented 3 years ago

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because of a no. of different jhipster blueprints are there, which are compatible and works with the different version of jhipster and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj rajpratik71@gmail.com

yelhouti commented 3 years ago

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

Rajpratik71 commented 3 years ago

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

I thought using that flag , but later i mached the version of jhipster

Rajpratik71 commented 3 years ago

thanks for the PR, you know you can use --skip-checks which ignores the versions right ?

Updated with flag

yelhouti commented 3 years ago

what I meant is: why would you use a docker image if you could call one command with all the blueprints and --skip-checks

Rajpratik71 commented 3 years ago

Build and run the generator from docker image support added.

The main aim and motivation behind doing this is, because of a no. of different jhipster blueprints are there, which are compatible and works with the different version of jhipster and also might be incompatible with other blueprints or versions of jhipster.

Signed-off-by: Pratik Raj rajpratik71@gmail.com

This is the aim and reason to provide generator as docker image

yelhouti commented 3 years ago

that is exactly my point, instead of having docker images, just call the genrator with --skip-checks isn't that much easier ?