search

tailosoft / jhipster-primeng-blueprint

This blueprint can be used to generate jhipster project with primeng frontend instead of bootstrap (work in progress)
Apache License 2.0
26 stars 20 forks source link

Update to Angular/PrimeNG 12/13/14 #48

Closed naris closed 1 year ago

naris commented 2 years ago

Currently this blueprint only supports Angular & PrimeNG 11. They should be updated at least 12, but really 13.

yelhouti commented 1 year ago

upgraded to support latest jhipster, specifically version: https://github.com/jhipster/generator-jhipster/pull/19849

naris commented 1 year ago

The update has an issue :( https://github.com/tailosoft/jhipster-primeng-blueprint/issues/58

naris commented 1 year ago

upgraded to support latest jhipster, specifically version: jhipster/generator-jhipster#19849

That is NOT the latest jhipster. The latest jhipster is https://www.jhipster.tech/2022/09/02/jhipster-release-7.9.3.html, not some branch.

That is not an acceptable solution!

yelhouti commented 1 year ago

@naris, there are to many changes between 7.9.3 and the main branch, and I wasn't willing to redo all the work in few weeks. We need to convince jhipster to merge composite so we don't have to maintain it. until then this is the only possible solution.

naris commented 1 year ago

@naris, there are to many changes between 7.9.3 and the main branch, and I wasn't willing to redo all the work in few weeks. We need to convince jhipster to merge composite so we don't have to maintain it. until then this is the only possible solution.

Then you should resolve the conflicts in https://github.com/jhipster/generator-jhipster/pull/19849

yelhouti commented 1 year ago

Feel free to help do that, I already did and new ones appeared

naris commented 1 year ago

I am sorry, I should not have complained and instead looked to see if I can fix it. You indeed don't have to do anything and I thank you for your open source contribution.