tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
551 stars 84 forks source link

Don't use hello.ipn.dev to check up status #11

Closed rosszurowski closed 2 years ago

rosszurowski commented 2 years ago

As of a few weeks ago, we no longer add hello.ipn.dev to new networks. If we're relying on these lines to successfully run the action, many new users may run into issues, along with existing users who have removed hello from their network.

https://github.com/tailscale/github-action/blob/cc6818dd6930277a6e4b5d249e32ba2f4cf6ea32/.github/workflows/tailscale.yml#L23-L25

DentonGentry commented 2 years ago

It isn't obvious, but:

rosszurowski commented 2 years ago

Ah, that makes more sense. I was surprised by that YAML file, but the fact that it uses action.yml rather than something in the workflows folder seems reasonable. Thanks!