tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
551 stars 84 forks source link

Create release for 1.18? #23

Closed dave-andersen closed 2 years ago

dave-andersen commented 2 years ago

Hi, TS folks - the bug that was fixed by this commit:

https://github.com/tailscale/github-action/commit/d1256d457746f421e7cd4c5e5855a6bce058eb24#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6

just bit us, causing a github worker to spin for 8 hours until we noticed it. 😂 Our workers didn't auto-grab the new version because there wasn't a new release.

Would it be possible to tag a new Release that incorporates the update to 1.18 and loop fix?

Thanks!

bradfitz commented 2 years ago

cc @DentonGentry @maisem

jazzdan commented 2 years ago

Would also be helpful for the new args feature added in b10fe7b66939938d10e203f6ae07776a5d135d08 :)

bxb100 commented 2 years ago

You can temporary using the commit id to use latest version uses: tailscale/github-action@ecdb6a2aed7b74d1c8ec0c78fbd76a84b9809b28

dagheyman commented 2 years ago

+1, was very confusing to try this action out and have the action spin forever :)

DentonGentry commented 2 years ago

main is currently on 1.24.