tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
532 stars 80 forks source link

tailscale/github-action@v1 is old #44

Closed milkcocoa closed 1 year ago

milkcocoa commented 2 years ago

I use this action with @v1 as follows.

- uses: tailscale/github-action@v1
  with:
    authkey: ${{ secrets.TAILSCALE_AUTHKEY }}

GitHub actions runner seems to use the old tailscale 1.14 version. Is this behavior intended?

DentonGentry commented 2 years ago

We applied the v1 tag to a rev which used 1.14. You can set a version input argument to control the Tailscale app version to use, if desired.

milkcocoa commented 2 years ago

Thanks. So, you don't have any plan to release minor versions to update the tailsscale version, right?

DentonGentry commented 2 years ago

It just seemed superfluous to add a v2, v3, v4, etc.

milkcocoa commented 2 years ago

Thanks, but I'm talking about the minor version instead of the major version, so when v1.0.1 (this is a patch version) or v1.1 is released with the latest version of tailscale, I can automatically track it with @v1.

But I don't have any strong reason to use the latest tailscale version, so if tailscale doesn't have any issue to use the older versions, I have no problem with that.

AlekSi commented 1 year ago

As funny as it sounds, GitHub recommends moving git tags for new releases. From https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

Move the major version tag (such as v1, v2) to point to the Git ref of the current release.

I would prefer this action to behave like other actions, even if it is not how git tags should be used “normally”.

DentonGentry commented 1 year ago

We are working on implementing OAuth client support in the action, which will be a v2 tag.

milkcocoa commented 1 year ago

Hmm, as my English is likely to be poor, there might be misunderstanding, but I was not talking about the major version releases in this thread.

AlekSi commented 1 year ago

If you tie it to v1 or to a git hash, you'll get that version of the github action forever

What I tried to say is that this is not how GitHub Actions typically work. If one uses actions/checkout@v3, they will not get that version of the action forever. Instead, they will get the latest v3.y.z. And this is achived my moving git tag: https://github.com/actions/checkout/tags – note that currently v3 and v3.3.0 point to the same commit, but v3.2.0 and older tags are still there.