search

tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
532 stars 80 forks source link

feat: add all params and default values #46

Closed XBeg9 closed 1 year ago

XBeg9 commented 1 year ago

It would be great to have directly typed args, instead of args and give an ability also to manage tailscaled.

willnorris commented 1 year ago

Many tailscale flags don't really make sense in a CI environment like GitHub Actions. So I think just blindly exposing all of them as action parameters creates a bit of noise for users, masking the more commonly use parameters, and extra work for trying to keep them in sync as flags are added or removed.

Instead, I think we'd be open to adding a few specific flags that are more likely to be used for CI. Looking at the results of this somewhat-imprecise search, it looks like --advertise-tags is the main additional flag that gets used, and would probably be worth exposing as an action parameter.

willnorris commented 1 year ago

With the addition of the tags param in #71 and tailscaled-args in #64, I think we've struck a good balance of "making the common things easy, and the uncommon things possible". If other flags prove to be particularly common in a CI environment, we'd be open to adding params for those specific flags at that time.