Closed michealroberts closed 1 year ago
I'm guessing it might be possible to do something like:
- name: Tailscale
uses: tailscale/github-action@v1
with:
authkey: ${{ secrets.TAILSCALE_EPHEMERAL_AUTH_KEY }}
version: "1.36.0"
In our ci.yml file ...
Seems like pinning the version as above fixes the issue and I can spawn a VPN on the right Tailscale version, however, it's rather odd that it is still spawning version 1.14 of Tailscale at the time of writing (15.04.2023) ...
The v1 tag is from the initial creation of this Action, and uses Tailscale version 1.14. We've updated the Tailscale version a few times, tying to @ce41a99162202a647a4b24c30c558a567b926709 (the current HEAD) instead of v1 would bring in a newer default Tailscale client.
We're expecting to make a v2 of this action when we've finished implementing OAuth client support.
@DentonGentry Ah fair. Do you know roughly when v2 will be released? (days, weeks, months ...?)
@DentonGentry Looks to be fixed by using @ce41a99162202a647a4b24c30c558a567b926709 and pinning the version to the rest of the VPN. Thank you 🙏
I think best practice is to keep updating the v1 tag with the latest commit until you publish a v2. It's how all the other GitHub actions work that I have used. Would it be possible to update the v1 tag so that following the README will work for all users?
I would tend to agree with @stephenwade ... I know it's a chore but this action should pull in the latest by default and have rolling changes, a v2 should only symbolise breaking changes to the actions options / setup / configuration (so anything user facing) in my humble, not changes to the underlying code that is triggered ...
I'm seeing the following when running in a Github Action:
I'm also seeing that version 1.14 is being spawned from this action which is not playing nicely as my other networks are on v1.36 (see screenshot below).
Is there a way to pin a specific version?