search

tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
532 stars 80 forks source link

Move 'tailscale up' to its own step. #65

Closed bradfitz closed 1 year ago

bradfitz commented 1 year ago

So tailscaled doesn't run with the authkey in its env. It doesn't need to know, so don't provide it. Defense in depth.

bradfitz commented 1 year ago

(untested)

bradfitz commented 1 year ago

I guess CI kinda tests it!

DentonGentry commented 1 year ago

CI needs one more thing: its authkey has expired... and I'm aware of the irony in that. I'm working on giving it a new fresh authkey, so we can see it pass.

DentonGentry commented 1 year ago

Gave it an updated authkey.

bradfitz commented 1 year ago

yay it passed

bradfitz commented 1 year ago

Hah, @maisem's approval is no good here?

DentonGentry commented 1 year ago

Hah, @maisem's approval is no good here?

Our usual administrator group had not been set up in this repo, though honestly I don't understand why that would make a difference. Nonetheless I just added it.