search

tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
567 stars 87 forks source link

add timeout on steps with network I/O #77

Closed willnorris closed 1 year ago

willnorris commented 1 year ago

Set a reasonable timeout to prevent jobs from hanging for hours (https://github.com/tailscale/github-action/issues/50). 5 minutes is way longer than should ever be necessary, but accounts for intermittent networking issues on either the actions runner or the Tailscale package or control server. Users can always set a shorter timeout on their own action step.

Fixes #50

willnorris commented 1 year ago

well I guess that answers that question... you can't specify timeout-minutes in actions.yml

https://github.com/tailscale/github-action/actions/runs/5414970481

willnorris commented 1 year ago

Yeah, I don't think we can do this in actions.yml. timeout isn't mentioned in their docs, but I was hoping it would still work. Looks like users will need to set it on their own. Maybe we just update the README to suggest a default value.

willnorris commented 1 year ago

or maybe we use the timeout command? Should be standard part of GNU coreutils

DentonGentry commented 1 year ago

I imagine curl has a timeout argument as well.