tailscale / github-action

A GitHub Action to connect your workflow to your Tailscale network.
BSD 3-Clause "New" or "Revised" License
519 stars 78 forks source link

Update Tailscale default version to 1.66.4 #95

Open evenh opened 8 months ago

evenh commented 8 months ago

I noticed that the default version was out of date, hence this PR.

venkatamutyala commented 1 month ago

It's 1.66.4 now.

jayvdb commented 1 month ago

Hi @evenh , could you update this to use the latest

evenh commented 1 month ago

Bumped!

Zebradil commented 1 month ago

Does it make sense to configure Renovate to update the version automatically?

evenh commented 1 month ago

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See https://github.com/tailscale/github-action/issues/28#issuecomment-1838519627

Zebradil commented 1 month ago

I would love that but it is up to the maintainers to decide. I hope they say yes in order to ensure that consumers are up to date.

See #28 (comment)

I haven't seen the comment you linked before, it seems reasonable to me.

The workaround is quite simple. In our workflows we currently use the following step to connect to the tailnet:

jobs:
  some-job:
    steps:
      - name: 'Tailscale'
        uses: 'tailscale/github-action@4e4c49acaa9818630ce0bd7a564372c17e33fb4d' # v2.0.0
        env:
          # See https://docs.renovatebot.com/presets-customManagers/#custommanagersgithubactionsversions
          # renovate: datasource=github-releases depName=tailscale/tailscale
          TAILSCALE_VERSION: '1.66.4'
        with:
          authkey: '${{ secrets.TAILSCALE_AUTHKEY }}'
          version: '${{ env.TAILSCALE_VERSION }}'

With the following bit in the renovate config:

{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["regexManagers:githubActionsVersions"]
}

The TAILSCALE_VERSION is only needed to use the built-in regexManagers:githubActionsVersions preset. If it is not desirable, one can define their own rule using the Regex Manager to update version in-place.