search

tailscale / gitops-acl-action

GitOps for your Tailscale ACLs
85 stars 25 forks source link

readme: fix actions/cache usage #14

Closed raggi closed 1 year ago

raggi commented 1 year ago

Explicitly name only the version-cache.json file to be cached, so as to not have the cache overwrite the policy.hujson file.

Create a new cache key for each successful run, and restore the latest key by ordered prefix match so as to avoid stale cache reads.

Fixes #7 Fixes #8 Fixes #11

filviu commented 1 year ago

Silly observation but I think https://tailscale.com/kb/1204/gitops-acls/ should also reflect this...

DentonGentry commented 1 year ago

Silly observation but I think https://tailscale.com/kb/1204/gitops-acls/ should also reflect this...

We've considered it but the text in the KB article lets people copy+paste it into their own Action along with whatever else they want the Action to do. Brevity in the KB article is most important, longer recipes become less useful for the target audience. So the KB article skips caching altogether; people are welcome to add caching in whatever it is they are doing in their Action.

filviu commented 1 year ago

Fair enough. Thank you !