search

tailscale / gitops-acl-action

GitOps for your Tailscale ACLs
85 stars 25 forks source link

action.yml: add separate steps for API key and OAuth flows #34

Closed mpminardi closed 8 months ago

mpminardi commented 8 months ago

Add separate steps for invocations of gitops-pusher for using API key and OAuth. These steps are triggered based on whether the inputs for the API key or OAuth secret are non-empty respectively. Add a check for whether both an API key and OAuth secret have been specified and error out in this case. Changing the logic in gitops-pusher to only attempt OAuth authentication when the provided secret is non-empty is likely also a desired change on top of this.

willnorris commented 8 months ago

ooh, I do like this as something we can do directly in the action as an immediate fix. @phirework is fixing the command itself in https://github.com/tailscale/tailscale/pull/11025

willnorris commented 8 months ago

Tested both styles of auth on my test tailnet, and this seems to be working well.