search

tailscale / golink

A private shortlink service for tailnets
BSD 3-Clause "New" or "Revised" License
1.25k stars 80 forks source link

Feature request: option to disable HTTPS #107

Closed tiesmaster closed 9 months ago

tiesmaster commented 10 months ago

It was really awesome to see that HTTPS was getting added in #99, to resolve #29, which helps workflows for some people. However, I'd rather have HTTPS turned off. I've configured my browser to ignore the missing HTTPS, and don't use the opensearch xml feature. One of the downsides of having this turned on, is that golink needs to acquire a new cert on initial deployment, which takes time to get the service live (not a big problem, but also a bit annoying).

I know you can turn off HTTPS from the Admin console, which I did, as I don't use the HTTPS feature of Tailscale atm. However, I'd like to be able to turn this on in the future, and don't get golink breaking on this, which I'll have completely forgotten about in a couple of months.

Yeah, I know, I guess XKCD 1172 is applicable ;) Though, I am willing to contribute a PR, which I'd gladly do. Would you be willing to accept a PR to add support for a configuration flag to override this behavior?

noncombatant commented 10 months ago

Hello @tiesmaster! Sure, if you send a PR, we'll take a look. Thanks! :)