search

tailscale / golink

A private shortlink service for tailnets
BSD 3-Clause "New" or "Revised" License
1.25k stars 79 forks source link

1.68 and auto updates #132

Closed lnlyssg closed 3 months ago

lnlyssg commented 5 months ago

The release notes for Tailscale 1.68 mention "Auto-updates are available for containers" so presumably if we can get an updated version of the golink container with 1.68 this should mean no more issues like #96 or #41 (or indeed this one)?

garfieldairlines commented 4 months ago

Just want to chime in : there's a security update available but I can't update the docker image just like that.

bradfitz commented 4 months ago

cc @awly

awly commented 4 months ago

Unfortunately, golink is a tsnet service, which is not the same thing as running tailscaled inside of a container. We do not have an auto-update mechanism for golink or tsnet services in general.

However, we need to be better about updating the Tailscale version for golink during our client releases. I'll nudge our client release owners to add it to the process.

bgiovand commented 3 months ago

Any updates on this?

awly commented 3 months ago

Updating golink is now a part of the release process, but looks like 1.72 got stuck due to some some regressions we were chasing in 1.72.0.

Our client release team should generally keep golink up-to-date going forward, so I'll close this issue.

lnlyssg commented 1 week ago

I think there are still issues as I've not seen any updates since 1.72.1....

awly commented 1 week ago

@lnlyssg apologies for that, latest version has now been published.

ItsJamesMurray commented 2 days ago

Perhaps I'm missing on how to update? I am installed with Docker via Portainer.

I am pulling ghcr.io/tailscale/golink:main and repulling for each update. I have '--sqlitedb' '/home/nonroot/golink.db' '--verbose' as the command and have mounted -v /persistent/data:/home/nonroot.

It still shows 1.57.0-dev20240126 in Tailscale for this "machine".

lnlyssg commented 2 days ago

Are you certain you are re-pulling? I'm also using Portainer but no issues here

ItsJamesMurray commented 2 days ago

I sure hope so! Its how im updating my other containers and it seems to work fine.

video showing process and still out of date go machine: [[removed]]

lnlyssg commented 2 days ago

Your image configuration doesn’t look right… you have dockerhub as the registry and the image field has docker.io pre-filled at the start. Can you check the Portainer logs? My guess it’s failing to pull a newer image so is just re-deploying the original one you used.

ItsJamesMurray commented 2 days ago

Ahh i tried that and it still didn't work. ended up SSH'ing in and running docker pull ghcr.io/tailscale/golink:main then finding the old image and removing it. Sorry for the weekend blunder!