search

tailscale / tailscale-client-go

A client implementation for the Tailscale HTTP API
MIT License
61 stars 27 forks source link

add expiry to key capabilities #34

Closed dizzzan closed 2 years ago

dizzzan commented 2 years ago

Need key expiry in the terraform provider, and I saw it was not yet added to the client pkg, but is available in the API. Will open separate PR for terraform provider, if this is approved. Thanks!

DentonGentry commented 2 years ago

This repo and the terraform repo require signed commits using either GPG or SSH keys. Are you set up to do that? If not, I can generate a PR with this change and sign it.

dizzzan commented 2 years ago

This repo and the terraform repo require signed commits using either GPG or SSH keys. Are you set up to do that? If not, I can generate a PR with this change and sign it.

Ah, just noticed that, sorry. I don't have signing set up on this computer. I can amend the PR later (I think pushing a new signed commit will suffice?), but feel free to generate a separate one instead. I also just created https://github.com/tailscale/terraform-provider-tailscale/pull/175 which will have the same issue :/

dizzzan commented 2 years ago

@DentonGentry pushed a signed commit, but it seems that didn't pass the check.

DentonGentry commented 2 years ago

There are two commits in this PR and the first is not signed, so it is rejected. I think you want to remove the second, signing commit: git reset --hard HEAD^1

Then sign the first commit: git commit --amend -S

Then force push it to the PR: git push -f

dizzzan commented 2 years ago

Bingo, thanks :)

davidsbond commented 2 years ago

Looks like this field has been added in the incorrect place based on #35 and the API documentation. Have added an example here