search

tailscale / tailscale-client-go

A client implementation for the Tailscale HTTP API
MIT License
61 stars 27 forks source link

Support setting comment for ACL #41

Closed matshch closed 9 months ago

matshch commented 1 year ago

There is a feature that allows to block ACL edits from admin console by specifying special comment in the top of the ACL: https://tailscale.com/kb/1204/gitops-acls/#prevent-others-from-accidentally-modifying-your-tailnet-policy-file However, there is no way to pass such comment when using Client's SetACL() method, because it only accepts ACL structure. Maybe it could be added via SetACLOption?

After adding it here it would be nice to add the same feature in https://github.com/tailscale/terraform-provider-tailscale.

bradfitz commented 1 year ago

We should also stop maintaining two clients and migrate the terraform provider to use https://pkg.go.dev/tailscale.com/client/tailscale

BestFriendChris commented 1 year ago

It's not just the comment at the top, I'd like it to also keep the comments within the file itself.