tailscale / tailscale-qpkg

Package Tailscale client in QPKG
MIT License
457 stars 38 forks source link

Routing disabled for LAN when LAN subnet is advertised by another device. "fixed" #100

Open DocEmmetBrown opened 1 year ago

DocEmmetBrown commented 1 year ago

This is a follow-up on https://github.com/tailscale/tailscale-qpkg/issues/74#issuecomment-1536551225 :

On my current install, I have one device advertising my home network (192.168.1.0/24). When enabling Tailscale on my Qnap 451 (x86_64 model, with latest QNAP OS 5), I loose all connectivity on the LAN interface, but the Tailscale interface works.

Getting a shell on the machine, and issuing ip rule add to 192.168.1.0/24 priority 2500 lookup main as per tailscale docs "fixes" the issue.

I was able to add that command to the autorun.sh script from the QNAP to have it persistent on reboot. see this qnap doc

It looks like the --accept-routes flag is enabled, which is not what is supposed to happen by default. 🤔

Since what is used to launch the service is tailscaled and not the tailscalecommand https://github.com/tailscale/tailscale-qpkg/blob/6cca342cc5c69d3d951f87de86230a9be377c24f/Tailscale/shared/Tailscale.sh#L25 I'm not sure how to disable the --accept-routes feature.

Happy to share more details on my config, and / or experiment with other settings.

Cheers,

gzxiexl commented 1 year ago

I also encountered the same problem, and I don't know how to set the default parameters

doug-fitzmaurice-rowden commented 1 year ago

Thanks @DocEmmetBrown, this was exactly the issue we were facing, and adding the appropriate ip rule.. command has resolved it.

talios commented 1 year ago

So is this issue going to be fixed in a new release at all? I see Tailscale is now in the official QNAP AppStore - and even tho it's an older release it now triggers this issue.

DentonGentry commented 1 year ago

Does turning off accepting of routes on the QNAP device resolve the routing issue?

/share/ZFS530_DATA/.qpkg/Tailscale/tailscale --socket=/tmp/tailscale/tailscaled.sock set --accept-routes=false

The path to the tailscale binary might differ on your system. ps auxw | grep tailscaled will give the full path to tailscaled, and the tailscale binary is in the same directory:

[dgentry@qnap-ts473a /]$ ps auxw | grep tailscale
 9069 dgentry     880 S   grep tailscale
11052 admin     88016 S   /share/ZFS530_DATA/.qpkg/Tailscale/tailscaled --port 41641 --statedir=/share/ZFS530_DATA/.qpkg/Tailscale/state --socket=/tmp/tailscale/tailscaled.sock
[dgentry@qnap-ts473a /]$
talios commented 1 year ago

On 14/06/2023 at 1:18:44 PM, Denton Gentry @.***> wrote:

Does turning off accepting of routes on the QNAP device resolve the routing issue?

/share/ZFS530_DATA/.qpkg/Tailscale/tailscale --socket=/tmp/tailscale/tailscaled.sock set --accept-routes=false

Didn’t appear to resolve anything for me no.

-- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree

talios commented 1 year ago

On 14/06/2023 at 4:17:56 PM, Mark Derricutt @.***> wrote:

Didn’t appear to resolve anything for me no.

Interesting - I updated my QNAP to use the latest 1.42.0 release and still couldn’t connect to anything, then remembered someone mentioned they could only connnect via IP - so I tried that and it worked.

Disabling Magic DNS and fixing the nas’s hostname seems to have resolved things ( seems every time I reinstall I get a new TS device registed so had nas50d992 and nas50d992-1 (the current one).

Mark

-- "Great artists are extremely selfish and arrogant things" — Steven Wilson, Porcupine Tree

Johan-Blacksquid commented 1 year ago

Does turning off accepting of routes on the QNAP device resolve the routing issue?

/share/ZFS530_DATA/.qpkg/Tailscale/tailscale --socket=/tmp/tailscale/tailscaled.sock set --accept-routes=false

The path to the tailscale binary might differ on your system. ps auxw | grep tailscaled will give the full path to tailscaled, and the tailscale binary is in the same directory:

[dgentry@qnap-ts473a /]$ ps auxw | grep tailscale
 9069 dgentry     880 S   grep tailscale
11052 admin     88016 S   /share/ZFS530_DATA/.qpkg/Tailscale/tailscaled --port 41641 --statedir=/share/ZFS530_DATA/.qpkg/Tailscale/state --socket=/tmp/tailscale/tailscaled.sock
[dgentry@qnap-ts473a /]$

Thanks, this solved my issue. Once Tailscale was installed on our Qnap server, devices within our LAN and not running Tailscale could not access the QNAP via the LAN IP address anymore. With this extra line of code, they have access again.

SiwyBoy commented 6 months ago

Does turning off accepting of routes on the QNAP device resolve the routing issue?

/share/ZFS530_DATA/.qpkg/Tailscale/tailscale --socket=/tmp/tailscale/tailscaled.sock set --accept-routes=false

The path to the tailscale binary might differ on your system. ps auxw | grep tailscaled will give the full path to tailscaled, and the tailscale binary is in the same directory:

[dgentry@qnap-ts473a /]$ ps auxw | grep tailscale
 9069 dgentry     880 S   grep tailscale
11052 admin     88016 S   /share/ZFS530_DATA/.qpkg/Tailscale/tailscaled --port 41641 --statedir=/share/ZFS530_DATA/.qpkg/Tailscale/state --socket=/tmp/tailscale/tailscaled.sock
[dgentry@qnap-ts473a /]$

Hi, I was trying to follow the instruction, but I'm receiving an error message: 2024/05/06 07:31:58 tailscaled does not take non-flag arguments: ["set" "--accept-routes=false"]

When pasted this line: ps auxw | grep tailscaled I'm getting:

 1908 admin     74460 S   /share/CACHEDEV1_DATA/.qpkg/Tailscale/tailscaled --port 41641 --statedir=/share/CACHEDEV1_DATA/.qpkg/Tailscale/state --socket=/tmp/tailscale/tailscaled.sock
 4712 artur.ad    456 S   grep tailscaled``

Am I missing something?