search

tailscale / tailscale-qpkg

Package Tailscale client in QPKG
MIT License
458 stars 38 forks source link

1.48.2 digital signature invalid #116

Closed marcozink closed 1 year ago

marcozink commented 1 year ago

Hello Team,

Seems that the latest package was not properly signed. This has happened before. Is there a way you can set the actions necessary to sign the package when a tag is released?

Thanks

bradfitz commented 1 year ago

/cc @awly @DentonGentry

awly commented 1 year ago

@marcozink what kind of package is it? Deb/rpm/something else?

marcozink commented 1 year ago

@awly In this case it's a qpkg since this repo is just for QNAP QTS

binnychan commented 1 year ago

Hi,

I am on QNAP TS-664 - QTS 5.1.1.2491 (2023/08/15) and use below qpkg. https://github.com/tailscale/tailscale-qpkg/releases/download/v1.48.2/Tailscale_1.48.2-1_x86.qpkg

Below is the error on "Event Log" Error 2023-09-13 10:27:22 --- --- Web Desktop Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.76 App Center App Installation [App Center] Failed to install Tailscale. The digital signature is invalid. To proceed with installation, go to App Center > Settings > General, and then select "Allow installation of applications without a valid digital signature".

Try https://github.com/tailscale/tailscale-qpkg/releases/download/v1.48.2/Tailscale_1.48.2-1_x86_64.qpkg

Same issue on "Event Log" Error 2023-09-13 10:33:03 --- --- Web Desktop Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36 Edg/116.0.1938.76 App Center App Installation [App Center] Failed to install Tailscale. The digital signature is invalid. To proceed with installation, go to App Center > Settings > General, and then select "Allow installation of applications without a valid digital signature".

DocEmmetBrown commented 1 year ago

I see the same thing with the Tailscale_1.48.2-1_x86_64.qpkg package. Digital signature is invalid

DentonGentry commented 1 year ago

The QNAP release is still done manually, we have not yet implemented it in the autobuilder. The manual process has to be able to build unsigned binaries, to allow people outside of Tailscale to build, so missing a step will result in not signing the packages.

I've uploaded replacement 1.48.2 packages which are signed.

marcozink commented 1 year ago

Thank you @DentonGentry I can confirm the new release is properly signed and has been installed without issues,

Thanks for the effort.