tailscale / tailscale

The easiest, most secure way to use WireGuard and 2FA.
https://tailscale.com
BSD 3-Clause "New" or "Revised" License
18.48k stars 1.42k forks source link

Windows client should grey out exit node selections if the device is advertised as an exit node #12771

Open garrett-ts opened 1 month ago

garrett-ts commented 1 month ago

What is the issue?

Advertising a Windows device as an exit node still shows other exit nodes in the tailnet or via Mullvad as selectable. Attempting to select an option closes the menu, silently failing.

Untitled 1

The devices should be greyed out to indicate they can't be used while it is running as an exit node. This is the behavior seen in the MacOS client. Additionally, attempting the same steps via the CLI generate a proper warning.

Untitled

Steps to reproduce

  1. Advertise a Windows device as an exit node
  2. Attempt to select an exit node from the client menu

Are there any recent changes that introduced the issue?

No response

OS

Windows

OS version

10

Tailscale version

1.68+

Other software

No response

Bug report

No response

catmur-tvt commented 1 month ago

I have two users with the same/similar issues... both Windows users (one on Win 10, the other on Win 11) who have only recently been onboarded with Tailscale. Both installed 1.68.2 and when they select an exit node, tailscale silently fails to select the exit node. I'm asking them to try 1.68.1 ... will post how that works out.

catmur-tvt commented 1 month ago

I have two users with the same/similar issues... both Windows users (one on Win 10, the other on Win 11) who have only recently been onboarded with Tailscale. Both installed 1.68.2 and when they select an exit node, tailscale silently fails to select the exit node. I'm asking them to try 1.68.1 ... will post how that works out.

Rolling back to 1.68.1 made no difference. Have also got another win11 machine running successfully on 1.68.2, so suspect this might be a different issue :-/

kelivel commented 1 month ago

@catmur-tvt Can they try the latest Windows unstable at https://pkgs.tailscale.com/unstable/#windows? Generate bug reports from each and send those to support@tailscale.com. We can take a closer look from there, and can add more details to this issue if it seems your issue is related.

catmur-tvt commented 1 month ago

@catmur-tvt Can they try the latest Windows unstable at https://pkgs.tailscale.com/unstable/#windows? Generate bug reports from each and send those to support@tailscale.com. We can take a closer look from there, and can add more details to this issue if it seems your issue is related.

Hi @kelivel - updates were sent through on ticket TSS-42242. FYI here, the unstable release (1.69.162) experienced the same issues. VPN access is up, but the selection of an exit node fails silently.

dblohm7 commented 1 month ago

I'm in the middle of a bunch of work on the exit node menu anyway, so I'll look into this.