DentonGentry
commented
1 year ago cc @DentonGentry who I think currently knows the most about the synology app
I believe you're correct about the version field not being used. It was never in our build instructions to increment it, so we never did, and nobody has noticed.
I think I would like to convert this config file to hujson in git, and have cmd/dist translate it back to plain JSON
Sure, that would be fine.
release/dist/synology/files/configis the file that becomesui/configin our Synology packages, and whose content describes our icon in the program list on the DSM UI, afaict.This file is partly documented in the developer guide (https://help.synology.com/developer-guide/integrate_dsm/config.html), but we're setting some fields that don't seem to exist, and some undocumented fields also seem to exist:
versionto 1.8.3, the version of Tailscale at which we added UI configuration to the app. AFAICT, this field doesn't exist, in either the developer docs or the empirically known undocumented fields used in the wild. I think we can just remove it?urlTarget, which is undocumented but is understood (via the synology community forum) to behave similarly to<a target=...>: it lets you specify a symbolic name for the DSM web GUI window that the app should open in, and specifically setting it ensures that trying to open the app multiple times just refreshes the same window rather than create more windows. This seems reasonable to keep.I think I would like to convert this config file to hujson in git, and have cmd/dist translate it back to plain JSON. In particular, I want to be able to add comments that link to the developer guide, and explain the undocumented field we're using.
Additionally, I think we should remove the
versionfield unless we have evidence that it's used. Empirically we've not updated it for several years and nobody's noticed or complained, which strongly suggests the field is not read at all by DSM.cc @DentonGentry who I think currently knows the most about the synology app, and cc @crawshaw who added the config originally and may have found something I didn't re:
version.