search

tailscale / walk

A Windows GUI toolkit for the Go Programming Language
Other
32 stars 5 forks source link

notifyicon.go: include contents of NOTIFYICONDATA argument in Shell_N… #68

Closed dblohm7 closed 4 months ago

dblohm7 commented 4 months ago

…otifyIcon error messages

Shell_NotifyIcon doesn't support any error codes beyond a boolean, but adding the input that was passed into the failing call could be very helpful here.

Updates https://github.com/tailscale/tailscale/issues/12472

dblohm7 commented 4 months ago

Yeah, we were actually doing that at one point on a temporary basis but I removed it again figuring that we had finally solved our Shell_NotifyIcon issues, there was no sense relying on underlying implementation details in the future.

Obviously we're now seeing problems again, so yeah, I'll throw that back in (at least for now).