Don’t unmount portal targets used by other portals

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

26.21k stars 1.09k forks source link

Don’t unmount portal targets used by other portals #3144

Closed thecrypticace closed 6 months ago

thecrypticace commented 6 months ago

Because of a timing issue we were unmounting the portal root when the open portals changed within the same tick. This PR keeps track of how many portals are using a given portal root and makes sure it is not unmounted until there are no more portals using it.

Fixes #3116 Fixes #2933

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	❌ Failed (Inspect)			Apr 26, 2024 4:24pm
headlessui-vue	❌ Failed (Inspect)			Apr 26, 2024 4:24pm