Make sure disabling demo mode on `<Combobox>` works

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

25.81k stars 1.07k forks source link

Make sure disabling demo mode on `<Combobox>` works #3182

Closed thecrypticace closed 4 months ago

thecrypticace commented 4 months ago

Our internal __demoMode prop that we use is intended to be disabled internally once a user interacts with the Combobox. However, we were incorrectly overriding this in a useMemo with the value of the prop which was always true.

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 7, 2024 6:03pm
headlessui-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 7, 2024 6:03pm