Fix crash when toggling between `virtual` and non-virtual mode in `Combobox` component

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

25.81k stars 1.07k forks source link

Fix crash when toggling between `virtual` and non-virtual mode in `Combobox` component #3236

Closed RobinMalfait closed 4 months ago

RobinMalfait commented 4 months ago

This PR fixes an issue where toggling between virtual and non-virtual mode would not correctly merge the virtual configuration and therefore it would crash the entire component.

This PR fixes that behavior and correctly switches to virtual mode. This also contains some internal refactors to clean things up related to virtual mode.

Fixes: #3235

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2024 4:11pm
headlessui-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2024 4:11pm