Ensure tabbing to a portalled `<PopoverPanel>` component moves focus inside (without using `<PortalGroup>`)

tailwindlabs / headlessui

Completely unstyled, fully accessible UI components, designed to integrate beautifully with Tailwind CSS.

https://headlessui.com

MIT License

25.81k stars 1.07k forks source link

Ensure tabbing to a portalled `<PopoverPanel>` component moves focus inside (without using `<PortalGroup>`) #3239

Closed RobinMalfait closed 4 months ago

RobinMalfait commented 4 months ago

This PR fixes a bug where pressing tab on a <PopoverButton> does not move focus inside of a portalled <PopoverPanel> component when it is opened and when you are not using a wrapping <PopoverGroup> component.

If you didn't use a <Portal /> or portal or anchor prop then this would not be an issue. If you used a <PopoverGroup /> then this would not be an issue.

Fixes: #3231

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
headlessui-react	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2024 9:40pm
headlessui-vue	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 24, 2024 9:40pm