Closed pschaub closed 2 weeks ago
During upgrading my code to the latest Headless UI version, I've seen that the default tags of ListboxOptions and ListboxOption changed, see https://github.com/tailwindlabs/headlessui/pull/3109
ListboxOptions
ListboxOption
I want that my code behaves the same so I was looking for an example in the documentation to change the type back to ul/li on ListboxOptions and ListboxOption.
ul
li
There I've found this example code:
<Listbox as="ul" value={selectedPerson} onChange={setSelectedPerson}> <ListboxButton as={MyCustomButton}>{selectedPerson.name}</ListboxButton> <ListboxOptions anchor="bottom" as="li"> {people.map((person) => ( <ListboxOption as="span" key={person.id} value={person} className="data-[focus]:bg-blue-100"> {person.name} </ListboxOption> ))} </ListboxOptions> </Listbox>
I would expect that
as="ul"
as="li"
So I suggest to update the documentation example accordingly:
<Listbox value={selectedPerson} onChange={setSelectedPerson}> <ListboxButton as={MyCustomButton}>{selectedPerson.name}</ListboxButton> <ListboxOptions anchor="bottom" as="ul"> {people.map((person) => ( <ListboxOption as="li" key={person.id} value={person} className="data-[focus]:bg-blue-100"> {person.name} </ListboxOption> ))} </ListboxOptions> </Listbox>
Whoops, appreciate you pointing this out! I've fixed the example code to use ul for ListboxOptions and li for ListboxOption. 👍
During upgrading my code to the latest Headless UI version, I've seen that the default tags of
ListboxOptions
andListboxOption
changed, see https://github.com/tailwindlabs/headlessui/pull/3109I want that my code behaves the same so I was looking for an example in the documentation to change the type back to
ul
/li
onListboxOptions
andListboxOption
.There I've found this example code:
I would expect that
as="ul"
is used onListboxOptions
as="li"
is used onListboxOption
So I suggest to update the documentation example accordingly: